Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: default member init #2211

Merged
merged 3 commits into from
Apr 15, 2022
Merged

clang-tidy: default member init #2211

merged 3 commits into from
Apr 15, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Apr 15, 2022

Signed-off-by: Rosen Penev [email protected]

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #2211 (3a8a8b2) into main (f3f6ffb) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2211      +/-   ##
==========================================
- Coverage   63.30%   63.30%   -0.01%     
==========================================
  Files         116      116              
  Lines       19600    19597       -3     
  Branches     9545     9545              
==========================================
- Hits        12408    12405       -3     
  Misses       5117     5117              
  Partials     2075     2075              
Impacted Files Coverage Δ
app/actions.hpp 100.00% <ø> (ø)
app/getopt.cpp 59.18% <ø> (-1.61%) ⬇️
include/exiv2/value.hpp 84.44% <ø> (ø)
src/tags.cpp 67.05% <ø> (-0.19%) ⬇️
src/value.cpp 72.78% <50.00%> (ø)
app/exiv2.cpp 62.58% <75.00%> (+0.04%) ⬆️
app/exiv2app.hpp 100.00% <100.00%> (ø)
app/getopt.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f6ffb...3a8a8b2. Read the comment docs.

This is rule of zero.

Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@piponazo piponazo merged commit 471b816 into Exiv2:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants